[Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

[Emil Velikov]

Hi Chad,

Please keep Tapani in Cc for the next revision - I think he can manage
the Android bits required.

There's a few small requests below, but don't bother if they're too
time consuming.

On 21 March 2017 at 23:02, Chad Versace <chadversary at chromium.org> wrote:

> +genxml/genX_bits.h: genxml/gen_bits_header.py
> +genxml/genX_bits.h: $(GENXML_PACK_GENERATED_FILES)
> +       $(MKDIR_GEN)
> +       $(AM_V_GEN) $(PYTHON2) $(srcdir)/genxml/gen_bits_header.py \
> +               $(GENXML_PACK_GENERATED_FILES) > $@ || ($(RM) $@; false)
Please provide the file[name] directly to the script rather than
piping stdout to file.

> +    /* THIS FILE HAS BEEN GENERATED, DO NOT HAND EDIT.
> +     *
> +     * Sizes of bitfields in genxml instructions, structures, and registers.
> +     */
> +
> +    #ifndef GENX_BITS_H
> +    #define GENX_BITS_H
> +

> +
> +    #endif /* GENX_BITS_H */
Here one can use the filename.

Thanks
Emil