[Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

Chad Versace chadversary at chromium.org
Wed Mar 22 21:05:46 UTC 2017


On Wed 22 Mar 2017, Emil Velikov wrote:
> Hi Chad,
> 
> Please keep Tapani in Cc for the next revision - I think he can manage
> the Android bits required.

Will do.

Also, I'm currently doing an initial build of android-ia, so I can stay
on top of the Android changes along with Tapani.

> There's a few small requests below, but don't bother if they're too
> time consuming.
> 
> On 21 March 2017 at 23:02, Chad Versace <chadversary at chromium.org> wrote:
> 
> > +genxml/genX_bits.h: genxml/gen_bits_header.py
> > +genxml/genX_bits.h: $(GENXML_PACK_GENERATED_FILES)
> > +       $(MKDIR_GEN)
> > +       $(AM_V_GEN) $(PYTHON2) $(srcdir)/genxml/gen_bits_header.py \
> > +               $(GENXML_PACK_GENERATED_FILES) > $@ || ($(RM) $@; false)

> Please provide the file[name] directly to the script rather than
> piping stdout to file.

Sure. I can add an '-o' option. That is, if I don't discard the script
in v4 of the series.


More information about the mesa-dev mailing list