[Mesa-dev] [PATCH 01/10] swr: [rasterizer codegen] Refactor codegen

[Rowley, Timothy O]

On Mar 27, 2017, at 5:06 AM, Emil Velikov <emil.l.velikov at gmail.com<mailto:emil.l.velikov at gmail.com>> wrote:

On 25 March 2017 at 12:00, Tim Rowley <timothy.o.rowley at intel.com<mailto:timothy.o.rowley at intel.com>> wrote:
Move common codegen functions into gen_common.py.
---
src/gallium/drivers/swr/Makefile.am                |  22 +--
.../drivers/swr/rasterizer/codegen/gen_archrast.py |  30 +---
.../drivers/swr/rasterizer/codegen/gen_backends.py |  30 +---
.../drivers/swr/rasterizer/codegen/gen_common.py   | 162 +++++++++++++++++++++
.../drivers/swr/rasterizer/codegen/gen_knobs.py    |  55 +++----
.../swr/rasterizer/codegen/gen_llvm_ir_macros.py   |  35 +----
.../swr/rasterizer/codegen/gen_llvm_types.py       |  32 +---
7 files changed, 212 insertions(+), 154 deletions(-)
create mode 100644 src/gallium/drivers/swr/rasterizer/codegen/gen_common.py

diff --git a/src/gallium/drivers/swr/Makefile.am b/src/gallium/drivers/swr/Makefile.am
index 8ba9ac9..3a0d8da 100644
--- a/src/gallium/drivers/swr/Makefile.am
+++ b/src/gallium/drivers/swr/Makefile.am
@@ -71,30 +71,30 @@ gen_swr_context_llvm.h: rasterizer/codegen/gen_llvm_types.py rasterizer/codegen/
               --input $(srcdir)/swr_context.h \
               --output ./gen_swr_context_llvm.h

-rasterizer/codegen/gen_knobs.cpp: rasterizer/codegen/gen_knobs.py rasterizer/codegen/knob_defs.py rasterizer/codegen/templates/gen_knobs.cpp
+rasterizer/codegen/gen_knobs.cpp: rasterizer/codegen/gen_knobs.py rasterizer/codegen/knob_defs.py rasterizer/codegen/templates/gen_knobs.cpp rasterizer/codegen/gen_common.py
       $(MKDIR_GEN)
       $(PYTHON_GEN) \
               $(srcdir)/rasterizer/codegen/gen_knobs.py \
-               --input $(srcdir)/rasterizer/codegen/templates/gen_knobs.cpp \
+               --input $(realpath $(srcdir)/rasterizer/codegen/templates/gen_knobs.cpp) \
Do we need this - there's no changes to the scons build.
If yet, abs_srcdir will give you the full path.

Don’t need it if gen_knobs.py is modified to find the template file internally, like the rest of our gen* scripts do.

v2 patch coming up shortly does that.

-Tim


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170327/55bba768/attachment.html>