[Mesa-dev] [PATCH 4/4] atomic: Initialise fence FD members

[Emil Velikov]

On 2 May 2017 at 11:52, Daniel Stone <daniels at collabora.com> wrote:
> ...
>
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> ---
>  drm-atomic.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drm-atomic.c b/drm-atomic.c
> index 25e04b1..6fb40fd 100644
> --- a/drm-atomic.c
> +++ b/drm-atomic.c
> @@ -368,6 +368,9 @@ const struct drm * init_drm_atomic(const char *device)
>         drm.crtc = calloc(1, sizeof(*drm.crtc));
>         drm.connector = calloc(1, sizeof(*drm.connector));
>
> +       drm.kms_in_fence_fd = -1;
> +       drm.kms_out_fence_fd = -1;
> +
Seems to be the correct place to handle here, despite that both are
already handled.

Patches 1/4 + 4/4 are
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

As a follow-up can we:
 - drop  atomic_run's "drm.kms_in_fence_fd = -1;" + git revert
a46366c9903efc8b63eb4e78ae72f869be0b0a3d
 - in drm_atomic_commit() use "(flags & DRM_MODE_ATOMIC_ALLOW_MODESET)
== 0" over "drm.kms_in_fence_fd != -1"

-Emil