[Mesa-dev] [PATCH 4/4] atomic: Initialise fence FD members

[Daniel Stone]

Hey Emil,

On 2 May 2017 at 14:24, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Seems to be the correct place to handle here, despite that both are
> already handled.

Honestly, I wouldn't have written this patch if I knew that; Lucas's
fix came in after the last time I'd pulled, and I didn't notice since
I didn't hit a conflict when I was rebasing. Oops.

> As a follow-up can we:
>  - drop  atomic_run's "drm.kms_in_fence_fd = -1;" + git revert
> a46366c9903efc8b63eb4e78ae72f869be0b0a3d

Dropping this in atomic_run() makes sense indeed, but honestly I think
Lucas's fix is fine as is.

>  - in drm_atomic_commit() use "(flags & DRM_MODE_ATOMIC_ALLOW_MODESET)
> == 0" over "drm.kms_in_fence_fd != -1"

I think this suggestion is wrong, or misleading at best. The
first-order thing we're interested in is if there's a fence available
to use (what the test now checks directly); the ALLOW_MODESET flag is
just a proxy for that. I'd rather not do this. I'll send another
related cleanup patch though.

Thanks for the review!

Cheers,
Daniel