[Mesa-dev] [PATCH 5/5] radv: drop unused surface level members.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue May 2 19:53:23 UTC 2017


Series is

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

Fee free to disregard my comment on patch 1, given that its
implementation is almost immediately overwritten.


On Tue, May 2, 2017 at 2:22 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_radeon_winsys.h                | 3 ---
>  src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 3 ---
>  2 files changed, 6 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_radeon_winsys.h b/src/amd/vulkan/radv_radeon_winsys.h
> index 5858cfe..5614d8b 100644
> --- a/src/amd/vulkan/radv_radeon_winsys.h
> +++ b/src/amd/vulkan/radv_radeon_winsys.h
> @@ -167,9 +167,6 @@ struct radeon_surf_info {
>  struct radeon_surf_level {
>         uint64_t                    offset;
>         uint64_t                    slice_size;
> -       uint32_t                    npix_x;
> -       uint32_t                    npix_y;
> -       uint32_t                    npix_z;
>         uint32_t                    nblk_x;
>         uint32_t                    nblk_y;
>         uint32_t                    nblk_z;
> diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c
> index 2cbf929..c972ef1 100644
> --- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c
> +++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c
> @@ -204,9 +204,6 @@ static int radv_compute_level(ADDR_HANDLE addrlib,
>         surf_level->offset = align64(surf->bo_size, AddrSurfInfoOut->baseAlign);
>         surf_level->slice_size = AddrSurfInfoOut->sliceSize;
>         surf_level->pitch_bytes = AddrSurfInfoOut->pitch * (is_stencil ? 1 : surf->bpe);
> -       surf_level->npix_x = u_minify(surf_info->width, level);
> -       surf_level->npix_y = u_minify(surf_info->height, level);
> -       surf_level->npix_z = u_minify(surf_info->depth, level);
>         surf_level->nblk_x = AddrSurfInfoOut->pitch;
>         surf_level->nblk_y = AddrSurfInfoOut->height;
>         if (type == RADEON_SURF_TYPE_3D)
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list