[Mesa-dev] [PATCH v2 0/2 Disable glthread is libX11 isn't thread-safe]

Gregory Hainaut gregory.hainaut at gmail.com
Wed May 3 16:34:27 UTC 2017


Hello,

Following the discussion from
https://lists.freedesktop.org/archives/mesa-dev/2017-April/153137.html

A check was added to ensure that X11 display can be locked. It should be enough
to ensure thread safety between X11 and glthread.

I also did the check on DRI3 as I'm not 100% sure that it is really thread safe.

EGL case is more tricky so the pair (X11/libX11) is marked as unsafe.
I think it is fine because modern EGL application should rely on XCB (on the X11
platform).

------------------------------------

v2: based on Nicolai/Matt reviews
Add a check on DRI extension version
Use C comments :)


Best regards,

Gregory Hainaut (2):
  glx|egl: allow to test if glthread is safe enough on X11 platform
  glthread/gallium: require safe_glthread to start glthread

 include/GL/internal/dri_interface.h          | 10 ++++++++
 src/egl/drivers/dri2/egl_dri2.c              | 34 +++++++++++++++++++++++++++-
 src/gallium/state_trackers/dri/dri_context.c | 12 ++++++++--
 src/glx/dri2_glx.c                           | 11 ++++++++-
 src/glx/dri3_glx.c                           | 10 +++++++-
 5 files changed, 72 insertions(+), 5 deletions(-)

-- 
2.11.0



More information about the mesa-dev mailing list