[Mesa-dev] [PATCH 3/3] egl/android: Mark surface as lost when dequeueBuffer fails

[Chad Versace]

On Thu 04 May 2017, Emil Velikov wrote:
> Hi Chad,
> 
> On 4 May 2017 at 00:47, Chad Versace <chadversary at chromium.org> wrote:
> > From: Chad Versace <chad at kiwitree.net>
> >
> > This ensures that future calls to eglSwapBuffers and eglMakeCurrent emit
> > an error.
> >
> > This patch is part of a series for fixing
> > android.hardware.camera2.cts.RobustnessTest#testAbandonRepeatingRequestSurface
> > on Chrome OS x86 devices.
> >
> Barring checking the wrong error as mentioned in 1/3 the issue should
> now be resolved, shouldn't it?
> Thinking out loud: perhaps it's worth having a similar test in dEQP?
> 
> > Cc: Tomasz Figa <tfiga at chromium.org>
> > Cc: Nicolas Boichat <drinkcat at chromium.org>
> > Cc: Tapani Pälli <tapani.palli at intel.com>
> IMHO your interpretation of the spec is spot on and the series look great.
> Other platforms can also make use of ::Lost (to varying extend) but
> that can follow at a later point.
> 
> For the lot
> Cc: mesa-stable at lists.freedesktop.org
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks for the quick review.