[Mesa-dev] [PATCH 3/3] egl/android: Mark surface as lost when dequeueBuffer fails

[Chad Versace]

On Thu, May 4, 2017, at 05:42 AM, Emil Velikov wrote:
> Hi Chad,
> 
> On 4 May 2017 at 00:47, Chad Versace <chadversary at chromium.org> wrote:
> > From: Chad Versace <chad at kiwitree.net>
> >
> > This ensures that future calls to eglSwapBuffers and eglMakeCurrent emit
> > an error.
> >
> > This patch is part of a series for fixing
> > android.hardware.camera2.cts.RobustnessTest#testAbandonRepeatingRequestSurface
> > on Chrome OS x86 devices.
> >
> Barring checking the wrong error as mentioned in 1/3 the issue should
> now be resolved, shouldn't it?

Yes, I've confirmed that the bug is now fixed.

> Thinking out loud: perhaps it's worth having a similar test in dEQP?

dEQP actually has a TODO for this. You can find it by grepping for
EGL_BAD_CURRENT_SURFACE.

I don't know how difficult it would be to write a dEQP for this. I
suspect you would need to
essentially write a different test for each platform because, to
reliably lose the surface, the
test would need to act on the native window between two eglSwapBuffers.