[Mesa-dev] [PATCH] bin/get-fixes-pick-list.sh: don't warn if more than one, go over them

Emil Velikov emil.l.velikov at gmail.com
Mon May 8 09:56:19 UTC 2017


On 6 May 2017 at 15:09, Andres Gomez <agomez at igalia.com> wrote:
> If an identified commit was having more than one fix, we would warn
> about that and only treat the first.
>
> Now, we don't warn but treat all of them.
>
Having read through this a couple of times, I'm not sure I fully parse it.

Are you saying that you want to flesh out all the commits when there's
multiple Fixes tags?

AFIACT that is not a wise idea, since a handful are corner cases like:
 - Fixes:\n $sha, Fixes: $piglit
 - Fixes: $sha.*Fixes:
and others.

In generally we have less than 5 of those every couple of weeks, so
trying to the corner cases is simply not worth it.
One has to skim through the commit message/patch either way.

-Emil


More information about the mesa-dev mailing list