[Mesa-dev] [PATCH] bin/get-fixes-pick-list.sh: don't warn if more than one, go over them

Andres Gomez agomez at igalia.com
Mon May 8 10:52:50 UTC 2017


On Mon, 2017-05-08 at 10:56 +0100, Emil Velikov wrote:
> On 6 May 2017 at 15:09, Andres Gomez <agomez at igalia.com> wrote:
> > If an identified commit was having more than one fix, we would warn
> > about that and only treat the first.
> > 
> > Now, we don't warn but treat all of them.
> > 
> 
> Having read through this a couple of times, I'm not sure I fully parse it.
> 
> Are you saying that you want to flesh out all the commits when there's
> multiple Fixes tags?

I'm not sure I'm understanding this previous sentence ...

> AFIACT that is not a wise idea, since a handful are corner cases like:
>  - Fixes:\n $sha, Fixes: $piglit
>  - Fixes: $sha.*Fixes:
> and others.

I'm unsure I get which is the problem you see in those 2 examples. At
least, not if it is not a problem that was already happening with the
cases in which only one "Fixes" tag was found.

Maybe you can elaborate on that?

-- 
Br,

Andres


More information about the mesa-dev mailing list