[Mesa-dev] [PATCH] configure.ac: Also match -androideabi tuple

[Nicolas Boichat]

On Mon, May 8, 2017 at 9:19 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 5 May 2017 at 23:40, Chad Versace <chadversary at chromium.org> wrote:
>> On Fri 05 May 2017, Nicolas Boichat wrote:
>>> From: Nicolas Boichat <drinkcat at chromium.org>
>>>
>>> On ARM Android platforms, the host_os tuple should be linux-androideabi,
>>> so let's match both -android and -androideabi (or any other
>>> -android* tuple) to determine if we should do an Android build.
>>> ---
>>>  configure.ac | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index a614458ab7c..df3eb6b29ac 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -269,7 +269,7 @@ DEFINES="-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS"
>>>  AC_SUBST([DEFINES])
>>>  android=no
>>>  case "$host_os" in
>>> -*-android)
>>> +*-android*)
>>>      android=yes
>>>      ;;
>>>  linux*|*-gnu*|gnu*|cygwin*)
>>
>> Reviewed-by: Chad Versace <chadversary at chromium.org>
>> And pushed.
> With the HAVE_ANDROID hunks removed [1] in master and 17.1.0 we might
> as well drop this. Do you guys have any OOT patches that depend on it?

Oh nice, I wasn't aware of that. We're still on some old 12.1.0 branch
(with a lot of backported patches), but there is a rebase effort
ongoing. And I don't think there's anything OOT that would require
HAVE_ANDROID, so AFAICT the we could drop this.

Thanks!

Best,

> -Emil
>
> [1]
> 79a26b663acdffc3f21d6e37f3334495aed16ae5
> 51accecce7755be9b7eb1baadaec7e4b7d1011af