[Mesa-dev] [PATCH] egl/android: Set EGLSurface.Lost to EGL_TRUE/EGL_FALSE

Nicolas Boichat drinkcat at chromium.org
Fri May 5 02:43:50 UTC 2017


Lost is an EGLBoolean, so we should assign it to EGL_TRUE/EGL_FALSE,
not true/false.

Fixes: e5eace58684 ("egl/android: Mark surface as lost when dequeueBuffer fails")
Fixes: 0212db35040 ("egl/android: Cancel any outstanding ANativeBuffer in surface destructor")
---
 src/egl/drivers/dri2/platform_android.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c
index 2450d9de476..b7276997879 100644
--- a/src/egl/drivers/dri2/platform_android.c
+++ b/src/egl/drivers/dri2/platform_android.c
@@ -271,7 +271,7 @@ droid_window_cancel_buffer(struct dri2_egl_surface *dri2_surf)
    ret = dri2_surf->window->cancelBuffer(dri2_surf->window, dri2_surf->buffer, -1);
    if (ret < 0) {
       _eglLog(_EGL_WARNING, "ANativeWindow::cancelBuffer failed");
-      dri2_surf->base.Lost = true;
+      dri2_surf->base.Lost = EGL_TRUE;
    }
 }
 
@@ -440,7 +440,7 @@ update_buffers(struct dri2_egl_surface *dri2_surf)
    /* try to dequeue the next back buffer */
    if (!dri2_surf->buffer && !droid_window_dequeue_buffer(dri2_surf)) {
       _eglLog(_EGL_WARNING, "Could not dequeue buffer from native window");
-      dri2_surf->base.Lost = true;
+      dri2_surf->base.Lost = EGL_TRUE;
       return -1;
    }
 
-- 
2.13.0.rc1.294.g07d810a77f-goog



More information about the mesa-dev mailing list