[Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

[Rob Clark]

This commit breaks 'glmark2 -b ideas' on a3xx..  probably a2xx too.
(a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..)
Nouveau also uses min/max_index, so wouldn't be surprised if this commit
causes problems there too..

Any particular need for this commit, or can I push a revert?

BR,
-R


On Wed, Apr 26, 2017 at 5:35 AM, Marek Olšák <maraeo at gmail.com> wrote:

> From: Marek Olšák <marek.olsak at amd.com>
>
> also remove the incorrect comment about primitive restart.
> ---
>  src/mesa/state_tracker/st_draw.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_
> draw.c
> index d710284..e510d43 100644
> --- a/src/mesa/state_tracker/st_draw.c
> +++ b/src/mesa/state_tracker/st_draw.c
> @@ -200,28 +200,23 @@ st_draw_vbo(struct gl_context *ctx,
>     if (ib) {
>        /* Get index bounds for user buffers. */
>        if (!index_bounds_valid)
>           if (!all_varyings_in_vbos(arrays))
>              vbo_get_minmax_indices(ctx, prims, ib, &min_index, &max_index,
>                                     nr_prims);
>
>        setup_index_buffer(st, ib);
>
>        info.indexed = TRUE;
> -      if (min_index != ~0U && max_index != ~0U) {
> -         info.min_index = min_index;
> -         info.max_index = max_index;
> -      }
> +      info.min_index = min_index;
> +      info.max_index = max_index;
>
> -      /* The VBO module handles restart for the non-indexed GLDrawArrays
> -       * so we only set these fields for indexed drawing:
> -       */
>        setup_primitive_restart(ctx, &info, ib->index_size);
>     }
>     else {
>        /* Transform feedback drawing is always non-indexed. */
>        /* Set info.count_from_stream_output. */
>        if (tfb_vertcount) {
>           if (!st_transform_feedback_draw_init(tfb_vertcount, stream,
> &info))
>              return;
>        }
>     }
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170508/0748c8df/attachment-0001.html>