[Mesa-dev] [PATCH 2/3] intel: compiler: remove duplicated code

[Matt Turner]

On Mon, May 8, 2017 at 3:02 PM, Lionel Landwerlin
<lionel.g.landwerlin at intel.com> wrote:
> CID: 1399470: (Control flow issues)
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Cc: Matt Turner <mattst88 at gmail.com>
> ---
>  src/intel/compiler/brw_eu_validate.c | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c
> index f231ea038b4..2db7c5a915c 100644
> --- a/src/intel/compiler/brw_eu_validate.c
> +++ b/src/intel/compiler/brw_eu_validate.c
> @@ -407,18 +407,6 @@ general_restrictions_based_on_operand_types(const struct gen_device_info *devinf
>     unsigned exec_size = 1 << brw_inst_exec_size(devinfo, inst);
>     struct string error_msg = { .str = NULL, .len = 0 };
>
> -   if (num_sources == 3)
> -      return (struct string){};
> -
> -   if (inst_is_send(devinfo, inst))
> -      return (struct string){};
> -
> -   if (exec_size == 1)
> -      return (struct string){};
> -
> -   if (desc->ndst == 0)
> -      return (struct string){};
> -
>     /* The PRMs say:
>      *
>      *    Where n is the largest element size in bytes for any source or

Whoops. Looks like a rebase failure.

I think we should remove the duplicate lines below the comment visible
at the end of this patch. With that fixed,

Reviewed-by: Matt Turner <mattst88 at gmail.com>