[Mesa-dev] [PATCH 1/3] genxml: Fix KSPs on Ironlake to be offsets, not pointers.

Jason Ekstrand jason at jlekstrand.net
Wed May 10 19:47:30 UTC 2017 

You can always use a NULL BO but this is fine too.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Wed, May 10, 2017 at 12:41 PM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> We use Instruction State Base Address on Ironlake, so we want KSP to be
> an offset not an actual pointer.  Gen4/G45 use pointers.
> ---
>  src/intel/genxml/gen5.xml | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml
> index 760eaccd721..3d80de9cf1e 100644
> --- a/src/intel/genxml/gen5.xml
> +++ b/src/intel/genxml/gen5.xml
> @@ -342,13 +342,13 @@
>    <struct name="CC_VIEWPORT" length="2">
>      <field name="Minimum Depth" start="0" end="31" type="float"/>
>      <field name="Maximum Depth" start="32" end="63" type="float"/>
>    </struct>
>
>    <struct name="CLIP_STATE" length="11">
> -    <field name="Kernel Start Pointer" start="6" end="31" type="address"/>
> +    <field name="Kernel Start Pointer" start="6" end="31" type="offset"/>
>      <field name="GRF Register Count" start="1" end="3" type="uint"/>
>      <field name="Single Program Flow" start="63" end="63" type="bool"/>
>      <field name="Binding Table Entry Count" start="50" end="57"
> type="uint"/>
>      <field name="Thread Priority" start="49" end="49" type="uint">
>        <value name="Normal Priority" value="0"/>
>        <value name="High Priority" value="1"/>
> @@ -452,13 +452,13 @@
>      <field name="Post-Blend Color Clamp Enable" start="192" end="192"
> type="bool"/>
>      <field name="Alpha Reference Value As UNORM8" start="224" end="255"
> type="uint"/>
>      <field name="Alpha Reference Value As FLOAT32" start="224" end="255"
> type="float"/>
>    </struct>
>
>    <struct name="GS_STATE" length="7">
> -    <field name="Kernel Start Pointer" start="6" end="31" type="address"/>
> +    <field name="Kernel Start Pointer" start="6" end="31" type="offset"/>
>      <field name="GRF Register Count" start="1" end="3" type="uint"/>
>      <field name="Single Program Flow" start="63" end="63" type="bool"/>
>      <field name="Binding Table Entry Count" start="50" end="57"
> type="uint"/>
>      <field name="Floating Point Mode" start="48" end="48" type="uint"
> prefix="FLOATING_POINT_MODE">
>        <value name="IEEE-754" value="0"/>
>        <value name="Alternate" value="1"/>
> @@ -703,13 +703,13 @@
>      <field name="Depth Coordinate Offset X" start="160" end="175"
> type="int"/>
>      <!-- DWord 6 -->
>      <!-- The hardware docs lie. There is no dword 6. -->
>    </instruction>
>
>    <struct name="SF_STATE" length="8">
> -    <field name="Kernel Start Pointer" start="6" end="31" type="address"/>
> +    <field name="Kernel Start Pointer" start="6" end="31" type="offset"/>
>      <field name="GRF Register Count" start="1" end="3" type="uint"/>
>      <field name="Single Program Flow" start="63" end="63" type="bool"/>
>      <field name="Binding Table Entry Count" start="50" end="57"
> type="uint"/>
>      <field name="Thread Priority" start="49" end="49" type="uint">
>        <value name="Normal Priority" value="0"/>
>        <value name="High Priority" value="1"/>
> @@ -828,13 +828,13 @@
>      <field name="Component 1 Control" start="56" end="58"
> type="3D_Vertex_Component_Control"/>
>      <field name="Component 2 Control" start="52" end="54"
> type="3D_Vertex_Component_Control"/>
>      <field name="Component 3 Control" start="48" end="50"
> type="3D_Vertex_Component_Control"/>
>    </struct>
>
>    <struct name="VS_STATE" length="7">
> -    <field name="Kernel Start Pointer" start="6" end="31" type="address"/>
> +    <field name="Kernel Start Pointer" start="6" end="31" type="offset"/>
>      <field name="GRF Register Count" start="1" end="3" type="uint"/>
>      <field name="Single Program Flow" start="63" end="63" type="bool"/>
>      <field name="Binding Table Entry Count" start="50" end="57"
> type="uint"/>
>      <field name="Thread Priority" start="49" end="49" type="uint">
>        <value name="Normal Priority" value="0"/>
>        <value name="High Priority" value="1"/>
> @@ -861,13 +861,13 @@
>      <field name="Sampler Count" start="160" end="162" type="uint"/>
>      <field name="Vertex Cache Disable" start="193" end="193" type="bool"/>
>      <field name="Function Enable" start="192" end="192" type="bool"/>
>    </struct>
>
>    <struct name="WM_STATE" length="11">
> -    <field name="Kernel Start Pointer" start="6" end="31" type="address"/>
> +    <field name="Kernel Start Pointer" start="6" end="31" type="offset"/>
>      <field name="GRF Register Count" start="1" end="3" type="uint"/>
>      <field name="Single Program Flow" start="63" end="63" type="bool"/>
>      <field name="Binding Table Entry Count" start="50" end="57"
> type="uint"/>
>      <field name="Thread Priority" start="49" end="49" type="uint">
>        <value name="High" value="1"/>
>      </field>
> @@ -920,17 +920,17 @@
>      <field name="Contiguous 32 Pixel Dispatch Enable" start="163"
> end="163" type="bool"/>
>      <field name="32 Pixel Dispatch Enable" start="162" end="162"
> type="bool"/>
>      <field name="16 Pixel Dispatch Enable" start="161" end="161"
> type="bool"/>
>      <field name="8 Pixel Dispatch Enable" start="160" end="160"
> type="bool"/>
>      <field name="Global Depth Offset Constant" start="192" end="223"
> type="float"/>
>      <field name="Global Depth Offset Scale" start="224" end="255"
> type="float"/>
> -    <field name="Kernel Start Pointer[1]" start="262" end="287"
> type="address"/>
> +    <field name="Kernel Start Pointer[1]" start="262" end="287"
> type="offset"/>
>      <field name="GRF Register Count[1]" start="257" end="259"
> type="uint"/>
> -    <field name="Kernel Start Pointer[2]" start="294" end="319"
> type="address"/>
> +    <field name="Kernel Start Pointer[2]" start="294" end="319"
> type="offset"/>
>      <field name="GRF Register Count[2]" start="289" end="291"
> type="uint"/>
> -    <field name="Kernel Start Pointer[3]" start="326" end="351"
> type="address"/>
> +    <field name="Kernel Start Pointer[3]" start="326" end="351"
> type="offset"/>
>      <field name="GRF Register Count[4]" start="321" end="323"
> type="uint"/>
>    </struct>
>
>    <instruction name="3DPRIMITIVE" bias="2" length="6">
>      <field name="Command Type" start="29" end="31" type="uint"
> default="3"/>
>      <field name="Command SubType" start="27" end="28" type="uint"
> default="3"/>
> --
> 2.12.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170510/f98f1df0/attachment.html>

More information about the mesa-dev mailing list