[Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

[Emil Velikov]

On 15 May 2017 at 13:25, Marek Olšák <maraeo at gmail.com> wrote:
> On Mon, May 15, 2017 at 1:11 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 13 May 2017 at 20:32, Marek Olšák <maraeo at gmail.com> wrote:
>>> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>>>
>>> Note that this is not meant for master, because master doesn't need this fix
>>> anymore.
>>>
>> A tad silly question: is that really the case?
>> AFAICT there's some related changes with commit 156e81f305b although
>> the patch seem applicable to master.
>
> The patch may apply cleanly, but I think it's not correct with the
> current code in master.
>
Right, thanks for the correction. Forwarding to mesa-stable.

Is it me or as-is the patch can cause null ptr deref? In all but one
case the counters ptr is NULL, yet most of the time one would read
more than one counter.
Perhaps one should use - if (regs->counters && regs->counters[idx])

-Emil