[Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

[Marek Olšák]

On Mon, May 15, 2017 at 4:31 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 15 May 2017 at 13:25, Marek Olšák <maraeo at gmail.com> wrote:
>> On Mon, May 15, 2017 at 1:11 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> On 13 May 2017 at 20:32, Marek Olšák <maraeo at gmail.com> wrote:
>>>> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>>>>
>>>> Note that this is not meant for master, because master doesn't need this fix
>>>> anymore.
>>>>
>>> A tad silly question: is that really the case?
>>> AFAICT there's some related changes with commit 156e81f305b although
>>> the patch seem applicable to master.
>>
>> The patch may apply cleanly, but I think it's not correct with the
>> current code in master.
>>
> Right, thanks for the correction. Forwarding to mesa-stable.
>
> Is it me or as-is the patch can cause null ptr deref? In all but one
> case the counters ptr is NULL, yet most of the time one would read
> more than one counter.
> Perhaps one should use - if (regs->counters && regs->counters[idx])

Please don't apply the patch to stable either. The patch is for a bug
that was on master for only 3 days:

Added here:
https://cgit.freedesktop.org/mesa/mesa/commit/?id=7088b655e8828bb960f528dd33132de27c505b8f
Reverted here:
https://cgit.freedesktop.org/mesa/mesa/commit/?id=314657dc11db651268ce5a0c9713337ddc68fe31

Marek