[Mesa-dev] [PATCH 7/9] mesa: GL_ARB_shader_subroutine is not optional in core profile

[Ilia Mirkin]

On Fri, May 19, 2017 at 9:38 AM, Ian Romanick <idr at freedesktop.org> wrote:
> diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py
> index 58d428d..850ce7d 100644
> --- a/src/mesa/main/get_hash_params.py
> +++ b/src/mesa/main/get_hash_params.py
> @@ -957,8 +957,8 @@ descriptor=[
>  # Enums restricted to OpenGL Core profile
>  { "apis": ["GL_CORE"], "params": [
>  # GL_ARB_shader_subroutine
> -  [ "MAX_SUBROUTINES", "CONST(MAX_SUBROUTINES), extra_ARB_shader_subroutine" ],
> -  [ "MAX_SUBROUTINE_UNIFORM_LOCATIONS", "CONST(MAX_SUBROUTINE_UNIFORM_LOCATIONS), extra_ARB_shader_subroutine" ],
> +  [ "MAX_SUBROUTINES", "CONST(MAX_SUBROUTINES), NO_EXTRA" ],
> +  [ "MAX_SUBROUTINE_UNIFORM_LOCATIONS", "CONST(MAX_SUBROUTINE_UNIFORM_LOCATIONS), NO_EXTRA" ],

We're not super-careful about this elsewhere, but perhaps it ought to
be EXTRA_API_GL_CORE?

Either way, 1-7 are Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>