[Mesa-dev] [PATCH v2 1/4] gallium: Add a cap to check if the driver supports ARB_post_depth_coverage

[Marek Olšák]

On Tue, May 23, 2017 at 9:10 PM, Lyude <lyude at redhat.com> wrote:
> Signed-off-by: Lyude <lyude at redhat.com>
>
> Changes since v1:
>  - Correct documentation in screen.rst for new cap
>
> Signed-off-by: Lyude <lyude at redhat.com>
> ---
>  src/gallium/docs/source/screen.rst               | 2 ++
>  src/gallium/drivers/etnaviv/etnaviv_screen.c     | 1 +
>  src/gallium/drivers/freedreno/freedreno_screen.c | 1 +
>  src/gallium/drivers/i915/i915_screen.c           | 1 +
>  src/gallium/drivers/llvmpipe/lp_screen.c         | 1 +
>  src/gallium/drivers/nouveau/nv30/nv30_screen.c   | 1 +
>  src/gallium/drivers/nouveau/nv50/nv50_screen.c   | 1 +
>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c   | 1 +
>  src/gallium/drivers/r300/r300_screen.c           | 1 +
>  src/gallium/drivers/r600/r600_pipe.c             | 1 +
>  src/gallium/drivers/radeonsi/si_pipe.c           | 1 +
>  src/gallium/drivers/softpipe/sp_screen.c         | 1 +
>  src/gallium/drivers/svga/svga_screen.c           | 1 +
>  src/gallium/drivers/swr/swr_screen.cpp           | 1 +
>  src/gallium/drivers/vc4/vc4_screen.c             | 1 +
>  src/gallium/drivers/virgl/virgl_screen.c         | 1 +
>  src/gallium/include/pipe/p_defines.h             | 1 +
>  17 files changed, 18 insertions(+)
>
> diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst
> index 871669c..ea28410 100644
> --- a/src/gallium/docs/source/screen.rst
> +++ b/src/gallium/docs/source/screen.rst
> @@ -392,6 +392,8 @@ The integer capabilities:
>  * ``PIPE_CAP_CAN_BIND_CONST_BUFFER_AS_VERTEX``: Whether a buffer with just
>    PIPE_BIND_CONSTANT_BUFFER can be legally passed to set_vertex_buffers.
>  * ``PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION``: As the name says.
> +* ``PIPE_CAP_POST_DEPTH_COVERAGE``: Whether running the depth coverage test
> +  before the execution of the fragment shader is supported.

There is no such thing as depth coverage test. ARB_post_depth_coverage
only changes the value of the SAMPLEMASK input to exclude samples that
failed the Z/S tests. It also enables the early fragment tests and
discards gl_FragDepth writes (and most likely also
ARB_shader_stencil_export outputs even though the spec doesn't mention
it).

Marek