[Mesa-dev] [PATCH V2] intel/compiler: Make use of IS_INTEGER_DWORD macro

Anuj Phogat anuj.phogat at gmail.com
Wed May 24 17:10:06 UTC 2017


On Wed, May 24, 2017 at 10:06 AM, Matt Turner <mattst88 at gmail.com> wrote:
> On Wed, May 24, 2017 at 9:21 AM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
>> This patch makes non-functional changes.
>>
>> V2: Rename IS_DWORD to IS_INTEGER_DWORD
>
>
> To be honest, I don't like IS_DWORD/IS_INTEGER_DWORD -- for the same
> reason Alejandro noted. It's not clear what it means exactly, and in
> most cases it would just be clearer to test against
> BRW_REGISTER_TYPE_D/UD.
>
> I'd prefer we removed IS_DWORD.
If it's not helping, I'm fine with dropping this patch.


More information about the mesa-dev mailing list