[Mesa-dev] [PATCH V2] intel/compiler: Make use of IS_INTEGER_DWORD macro

Kenneth Graunke kenneth at whitecape.org
Fri May 26 08:06:02 UTC 2017


On Wednesday, May 24, 2017 10:06:01 AM PDT Matt Turner wrote:
> On Wed, May 24, 2017 at 9:21 AM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
> > This patch makes non-functional changes.
> >
> > V2: Rename IS_DWORD to IS_INTEGER_DWORD
> 
> 
> To be honest, I don't like IS_DWORD/IS_INTEGER_DWORD -- for the same
> reason Alejandro noted. It's not clear what it means exactly, and in
> most cases it would just be clearer to test against
> BRW_REGISTER_TYPE_D/UD.
> 
> I'd prefer we removed IS_DWORD.

Yeah, I'm not crazy about it either...I think just checking the types
is clearer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170526/e066c871/attachment.sig>


More information about the mesa-dev mailing list