[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue May 30 23:03:11 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=100613

--- Comment #32 from Roland Scheidegger <sroland at vmware.com> ---
(In reply to Ben Crocker from comment #29)
> Created attachment 131577 [details] [review]
> Patch to lp_build_gather_elem_vec
> 
> THIS is the attachment I meant to attach to Comment 28.

Yes, that looks like it could work. Albeit the code in gather really ought to
work too if we'd decided to fetch 4x16 values the same way as 3x16 (so, as a
single 64bit value instead of 2x32) and I don't think that's the case.
In any case, you should send any patches you think are ready to mesa-dev. (This
particular patch would need some comments, plus you should use a helper for
constructing the type16 type - I don't think we ever initialize those
directly.)
I think though overall this is still all quite messy (I'd be fine with just
always doing vector-as-scalar or vector-as-vector fetch on BE (both for the soa
format code and gather code) and not both if it means I'm going to break those
paths less often...)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170530/e923e0ef/attachment.html>


More information about the mesa-dev mailing list