[Mesa-dev] [PATCH 15/30] i965/miptree: Add new entrypoints for resolve management

[Pohjolainen, Topi]

On Fri, May 26, 2017 at 04:30:19PM -0700, Jason Ekstrand wrote:
> This commit adds a new unified interface for doing resolves.  The basic
> format is that, prior to any surface access such as texturing or
> rendering, you call intel_miptree_prepare_access.  If the surface was
> written, you call intel_miptree_finish_write.  These two functions take
> parameters which tell them whether or not auxiliary compression and fast
> clears are supported on the surface.  Later commits will add wrappers
> around these two functions for texturing, rendering, etc.
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 156 +++++++++++++++++++++++++-
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h |  80 +++++++++++++
>  2 files changed, 232 insertions(+), 4 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index 6cd32ce..0659e75 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -2028,8 +2028,7 @@ bool
>  intel_miptree_all_slices_resolve_hiz(struct brw_context *brw,
>  				     struct intel_mipmap_tree *mt)
>  {
> -   return intel_miptree_depth_hiz_resolve(brw, mt,
> -                                          0, UINT32_MAX, 0, UINT32_MAX,
> +   return intel_miptree_depth_hiz_resolve(brw, mt, 0, UINT32_MAX, 0, UINT32_MAX,
>                                            BLORP_HIZ_OP_HIZ_RESOLVE);
>  }
>  
> @@ -2037,8 +2036,7 @@ bool
>  intel_miptree_all_slices_resolve_depth(struct brw_context *brw,
>  				       struct intel_mipmap_tree *mt)
>  {
> -   return intel_miptree_depth_hiz_resolve(brw, mt,
> -                                          0, UINT32_MAX, 0, UINT32_MAX,
> +   return intel_miptree_depth_hiz_resolve(brw, mt, 0, UINT32_MAX, 0, UINT32_MAX,
>                                            BLORP_HIZ_OP_DEPTH_RESOLVE);
>  }
>  
> @@ -2221,6 +2219,156 @@ intel_miptree_all_slices_resolve_color(struct brw_context *brw,
>     intel_miptree_resolve_color(brw, mt, 0, UINT32_MAX, 0, UINT32_MAX, flags);
>  }
>  
> +void
> +intel_miptree_prepare_access(struct brw_context *brw,
> +                             struct intel_mipmap_tree *mt,
> +                             uint32_t start_level, uint32_t num_levels,
> +                             uint32_t start_layer, uint32_t num_layers,
> +                             bool aux_supported, bool fast_clear_supported)

Well, I might as well throw in my preference on using enumarated flags instead 
of booleans. In call sites, for exmaple,

intel_miptree_prepare_access(brw, mt, start_level, num_levels,
                             start_layer, num_layers,
                             INTEL_SUPPORT_AUX | INTEL_SUPPORT_FAST_CLEAR);

is more informative than

intel_miptree_prepare_access(brw, mt, start_level, num_levels,
                             start_layer, num_layers,
                             true, true);

Former also allows adding more flags without changing the signature.