[Mesa-dev] [PATCH 1/3] radv: copy indirect lowering settings from radeonsi
bas at basnieuwenhuizen.nl
Tue Nov 7 09:00:48 UTC 2017
From: Timothy Arceri <tarceri at itsqueeze.com>
It looks the original indirect mask was probably copied from
Sascha Willems demo results:
tessellation ~4000 -> ~4200 fps
V2: continue lowering local indirects due to llvm deficiencies.
(backport from 087e010b2b3dd83a539f97203909d6)
src/amd/vulkan/radv_pipeline.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index ddd146424e8..e5487fa665c 100644
@@ -275,8 +275,28 @@ radv_shader_compile_to_nir(struct radv_device *device,
+ /* While it would be nice not to have this flag, we are constrained
+ * by the reality that LLVM 5.0 doesn't have working VGPR indexing
+ * on GFX9.
+ bool llvm_has_working_vgpr_indexing =
+ device->physical_device->rad_info.chip_class <= VI;
+ /* TODO: Indirect indexing of GS inputs is unimplemented.
+ * TCS and TES load inputs directly from LDS or offchip memory, so
+ * indirect indexing is trivial.
nir_variable_mode indirect_mask = 0;
indirect_mask |= nir_var_shader_in;
+ /* TODO: We shouldn't need to do this, however LLVM isn't currently
+ * smart enough to handle indirects without causing excess spilling
+ * causing the gpu to hang.
+ * See the following thread for more details of the problem:
+ * https://lists.freedesktop.org/archives/mesa-dev/2017-July/162106.html
indirect_mask |= nir_var_local;
More information about the mesa-dev