[Mesa-dev] [PATCH 3/3] radv: Disallow indirect outputs for GS on GFX9 as well.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue Nov 7 09:00:50 UTC 2017


Since it also uses the output vector before writing to memory.

Fixes: e38685cc62e 'Revert "radv: disable support for VEGA for now."'
Reviewed-by: Dave Airlie <airlied at redhat.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

(cherry-picked from c07d719e8b683e1bf78f187dd17fe4716f4e5e9c)
---
 src/amd/vulkan/radv_pipeline.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index 56b987afda9..bf010268cb8 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -290,10 +290,8 @@ radv_shader_compile_to_nir(struct radv_device *device,
 	nir_variable_mode indirect_mask = 0;
 	indirect_mask |= nir_var_shader_in;
 
-        if (!llvm_has_working_vgpr_indexing &&
-	    (nir->info.stage == MESA_SHADER_VERTEX ||
-	     nir->info.stage == MESA_SHADER_TESS_EVAL ||
-	     nir->info.stage == MESA_SHADER_FRAGMENT))
+	if (!llvm_has_working_vgpr_indexing &&
+	    nir->info.stage != MESA_SHADER_TESS_CTRL)
 		indirect_mask |= nir_var_shader_out;
 
         /* TODO: We shouldn't need to do this, however LLVM isn't currently
-- 
2.15.0



More information about the mesa-dev mailing list