[Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

Eric Anholt eric at anholt.net
Wed Nov 8 23:19:50 UTC 2017


Dylan Baker <dylan at pnwbakers.com> writes:

> [ Unknown signature status ]
> Quoting Eric Anholt (2017-11-08 14:14:57)
>> ---
>>  meson.build                         |  5 +++--
>>  src/gallium/drivers/vc4/meson.build | 13 +++++++++++++
>>  2 files changed, 16 insertions(+), 2 deletions(-)
>> 
>> diff --git a/meson.build b/meson.build
>> index 0118c9a7c5ef..189c9be5b59c 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -485,8 +485,9 @@ endif
>>  
>>  # FIXME: enable asm when cross compiler
>>  # This is doable (autotools does it), but it's not of immediate concern
>> -if meson.is_cross_build()
>> -  message('Cross compiling, disabling asm')
>> +if meson.is_cross_build() and (host_machine.cpu_family() == 'x86' or
>> +                               host_machine.cpu_family() == 'x86_64')
>
> How about:
> if meson.is_cross_build() and host_machine.cpu_family().startswith('x86')
>
> Other than that, for the series:
> Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

I like it.  Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171108/b14e3494/attachment.sig>


More information about the mesa-dev mailing list