[Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

[Eric Engestrom]

On Wednesday, 2017-11-08 15:19:50 -0800, Eric Anholt wrote:
> Dylan Baker <dylan at pnwbakers.com> writes:
> 
> > [ Unknown signature status ]
> > Quoting Eric Anholt (2017-11-08 14:14:57)
> >> ---
> >>  meson.build                         |  5 +++--
> >>  src/gallium/drivers/vc4/meson.build | 13 +++++++++++++
> >>  2 files changed, 16 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/meson.build b/meson.build
> >> index 0118c9a7c5ef..189c9be5b59c 100644
> >> --- a/meson.build
> >> +++ b/meson.build
> >> @@ -485,8 +485,9 @@ endif
> >>  
> >>  # FIXME: enable asm when cross compiler
> >>  # This is doable (autotools does it), but it's not of immediate concern
> >> -if meson.is_cross_build()
> >> -  message('Cross compiling, disabling asm')
> >> +if meson.is_cross_build() and (host_machine.cpu_family() == 'x86' or
> >> +                               host_machine.cpu_family() == 'x86_64')
> >
> > How about:
> > if meson.is_cross_build() and host_machine.cpu_family().startswith('x86')
> >
> > Other than that, for the series:
> > Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
> 
> I like it.  Thanks!

Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>