[Mesa-dev] [PATCH 3/4] util/disk_cache: Make zlib support optional

Timothy Arceri tarceri at itsqueeze.com
Sat Nov 11 00:44:40 UTC 2017


On 11/11/17 08:49, Jordan Justen wrote:
> On 2017-11-10 13:15:10, Matt Turner wrote:
>> Why?
> 
> For patch 4. Patch 4 can't happen unless zlib is optional because it's
> a pain to enable zlib on windows.
> 
> No surprise, but the disk cache actually works without zlib. (Of
> course, Tim originally implemented it without compression.)

To be honest i really don't like this. Without compression the disk 
cache is not great, for example Deus Ex shaders took up around 130MB 
(over 1/10 of the default cache size). IMO we should just disable 
building the cache when zlib is not found ... actually I'm pretty sure 
building this is already disabled on windows because its very unixy.

Not having compression is fine for the program binary extension but I'd 
rather not do it for the disk cache.

> 
> -Jordan
> 


More information about the mesa-dev mailing list