[Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

[Rob Clark]

hmm, well autotools build built it by default, and it's contribution
to build time is negligible vs addition of even more config options..

perhaps it is really only useful for debug builds, so I'd be ok with
the approach of only building it for debug builds

BR,
-R


On Sat, Nov 11, 2017 at 11:11 AM, Dylan Baker <dylan at pnwbakers.com> wrote:
> I sent a patch to fix this as did Rob, I think his landed already.
>
> I'm not sure it's a good idea to build tools by default. Personally I'd rather see an extra option added if compiling via ninja src/gallium/drivers/freedreno/ir3compiler is too tedious.
>
> Dylan
>
> On November 10, 2017 11:10:37 PM PST, Jason Ekstrand <jason at jlekstrand.net> wrote:
>>Setting build_by_default to true makes it suddenly pull in freedreno
>>and
>>all of gallium unconditionally.
>>
>>Cc: Rob Clark <robdclark at gmail.com>
>>Cc: Dylan Baker <dylan at pnwbakers.com>
>>---
>> src/gallium/drivers/freedreno/meson.build | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/src/gallium/drivers/freedreno/meson.build
>>b/src/gallium/drivers/freedreno/meson.build
>>index 3fb94ed..b3a33da 100644
>>--- a/src/gallium/drivers/freedreno/meson.build
>>+++ b/src/gallium/drivers/freedreno/meson.build
>>@@ -224,5 +224,5 @@ ir3_compiler = executable(
>>     libglsl_standalone,
>>     libmesa_util,
>>   ],
>>-  build_by_default : true,
>>+  build_by_default : with_gallium_freedreno,
>> )