[Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

[Jason Ekstrand]

On Sat, Nov 11, 2017 at 8:11 AM, Dylan Baker <dylan at pnwbakers.com> wrote:

> I sent a patch to fix this as did Rob, I think his landed already.
>

Yeah...  I still kind-of like the way my patch works.  I personally think
it's way nicer to predicate build targets on boolean configure flags rather
than setting build_by_default to true and then conditionally including the
file.  Maybe that's a silly style choice, but I really like it.


> I'm not sure it's a good idea to build tools by default. Personally I'd
> rather see an extra option added if compiling via ninja
> src/gallium/drivers/freedreno/ir3compiler is too tedious.
>

I'm kind-of thinking we want an install-dev-tools flag which will cause all
dev tools to build and install if you're already building the relevant
driver.


> Dylan
>
> On November 10, 2017 11:10:37 PM PST, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> >Setting build_by_default to true makes it suddenly pull in freedreno
> >and
> >all of gallium unconditionally.
> >
> >Cc: Rob Clark <robdclark at gmail.com>
> >Cc: Dylan Baker <dylan at pnwbakers.com>
> >---
> > src/gallium/drivers/freedreno/meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/src/gallium/drivers/freedreno/meson.build
> >b/src/gallium/drivers/freedreno/meson.build
> >index 3fb94ed..b3a33da 100644
> >--- a/src/gallium/drivers/freedreno/meson.build
> >+++ b/src/gallium/drivers/freedreno/meson.build
> >@@ -224,5 +224,5 @@ ir3_compiler = executable(
> >     libglsl_standalone,
> >     libmesa_util,
> >   ],
> >-  build_by_default : true,
> >+  build_by_default : with_gallium_freedreno,
> > )
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171111/1bce3fcb/attachment.html>