[Mesa-dev] [PATCH 1/2] intel/tools: Fix detection of enabled shader stages.

Lionel Landwerlin lionel.g.landwerlin at intel.com
Sat Nov 11 23:26:46 UTC 2017


Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 11/11/17 00:55, Kenneth Graunke wrote:
> We renamed "Function Enable" to "Enable", which broke our detection
> of whether shaders are enabled or not.  So, we'd see a bunch of HS/DS
> packets with program offsets of 0, and think that was a valid TCS/TES.
>
> Fixes: c032cae9ff77e (genxml: Rename "Function Enable" to "Enable".)
> ---
>   src/intel/tools/aubinator_error_decode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c
> index 4035723b87d..2322bac8391 100644
> --- a/src/intel/tools/aubinator_error_decode.c
> +++ b/src/intel/tools/aubinator_error_decode.c
> @@ -367,7 +367,7 @@ static void decode(struct gen_spec *spec,
>                  is_simd8 = strcmp(iter.value, "true") == 0;
>               } else if (strcmp(iter.name, "Dispatch Enable") == 0) {
>                  is_simd8 = strcmp(iter.value, "SIMD8") == 0;
> -            } else if (strcmp(iter.name, "Function Enable") == 0) {
> +            } else if (strcmp(iter.name, "Enable") == 0) {
>                  is_enabled = strcmp(iter.value, "true") == 0;
>               }
>            }




More information about the mesa-dev mailing list