[Mesa-dev] [PATCH 2/2] intel/tools: Fix program disassembly in aubinator_error_decode.

[Kenneth Graunke]

On Saturday, November 11, 2017 3:35:21 PM PST Lionel Landwerlin wrote:
> :(
> 
> The intention was to deal with cases where we've encountered more than 
> MAX_NUM_PROGRAMS (actually happened to me).
> So we start by the index + 1 assuming this is the oldest program because 
> we're in a rolling window of programs.
> 
> This is obviously broken with the < 4096 programs case. Maybe we should 
> just replace idx with :
> 
> idx = ((num_programs == MAX_NUM_PROGRAMS ? idx_program : 0) + i) % 
> MAX_NUM_PROGRAMS;

Okay, let's drop this patch.  I just sent an 11 patch series which
includes patches to drop the arbitrary 4096 limit altogether, and
decodes shaders near the packets, like regular aubinator does.

That should work out better in both cases :)

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171112/bb469743/attachment.sig>