[Mesa-dev] [PATCH 07/18] intel/compiler: fix for memmove argument on annotating error

[Matt Turner]

On Mon, Nov 13, 2017 at 1:12 PM, Rogovin, Kevin <kevin.rogovin at intel.com> wrote:
> Hi,
>
>
>  I confess I am not 100% on this code and I did educated guessing what it is  trying to do; I figured it was trying to insert contents at the current index i; and that ann_count is the size -after- the insert. thus I figured the memmove is to move the half open interval [i, ann_count-1) to the half open interval [i + 1, ann_count). The number of elements in the half open range [i, ann_count - 1) is given by ann_count - i - 1.
>
> I tried changing the count from ann_count - i - 1 to ann_count - i + 1 and then the disassembler crashed in annotation on the same shaders that I have had it crash on before.

Interesting. Could you send me the shader binary? I'll take a look.