[Mesa-dev] [PATCH 1/3] radv: drop radv_cmd_dirty_mask_t typedef

[Bas Nieuwenhuizen]

For the series

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Tue, Nov 14, 2017 at 5:27 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> I don't think we will need a 64-bit unsigned integer for the
> dirty flags in the future, and there is still 20 bits left.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_pipeline.c | 2 +-
>  src/amd/vulkan/radv_private.h  | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
> index f006dc98c0..faffca8330 100644
> --- a/src/amd/vulkan/radv_pipeline.c
> +++ b/src/amd/vulkan/radv_pipeline.c
> @@ -1019,7 +1019,7 @@ static void
>  radv_pipeline_init_dynamic_state(struct radv_pipeline *pipeline,
>                                  const VkGraphicsPipelineCreateInfo *pCreateInfo)
>  {
> -       radv_cmd_dirty_mask_t states = RADV_CMD_DIRTY_DYNAMIC_ALL;
> +       uint32_t states = RADV_CMD_DIRTY_DYNAMIC_ALL;
>         RADV_FROM_HANDLE(radv_render_pass, pass, pCreateInfo->renderPass);
>         struct radv_subpass *subpass = &pass->subpasses[pCreateInfo->subpass];
>
> diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h
> index 4281cd39c1..2de3eccf0e 100644
> --- a/src/amd/vulkan/radv_private.h
> +++ b/src/amd/vulkan/radv_private.h
> @@ -702,7 +702,6 @@ enum radv_cmd_dirty_bits {
>         RADV_CMD_DIRTY_INDEX_BUFFER                      = 1 << 10,
>         RADV_CMD_DIRTY_FRAMEBUFFER                       = 1 << 11,
>  };
> -typedef uint32_t radv_cmd_dirty_mask_t;
>
>  enum radv_cmd_flush_bits {
>         RADV_CMD_FLAG_INV_ICACHE = 1 << 0,
> @@ -817,7 +816,7 @@ struct radv_cmd_state {
>
>         bool                                          push_descriptors_dirty;
>         bool predicating;
> -       radv_cmd_dirty_mask_t                         dirty;
> +       uint32_t                                      dirty;
>
>         struct radv_pipeline *                        pipeline;
>         struct radv_pipeline *                        emitted_pipeline;
> --
> 2.15.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev