[Mesa-dev] [PATCH] radv: do not add the query pool BO to the list in vkCmdEndQuery()

Samuel Pitoiset samuel.pitoiset at gmail.com
Wed Nov 15 09:55:05 UTC 2017


As per the spec, the query identified by queryPool and query
must currently be active. Applications have to call vkCmdBeginQuery()
before, and thus the query pool BO will already be in the list.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/vulkan/radv_query.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
index 6a80740ce0..5dc88af8f8 100644
--- a/src/amd/vulkan/radv_query.c
+++ b/src/amd/vulkan/radv_query.c
@@ -1125,7 +1125,9 @@ void radv_CmdEndQuery(
 	uint64_t avail_va = va + pool->availability_offset + 4 * query;
 	va += pool->stride * query;
 
-	radv_cs_add_buffer(cmd_buffer->device->ws, cs, pool->bo, 8);
+	/* Do not need to add the pool BO to the list because the query must
+	 * currently be active, which means the BO is already in the list.
+	 */
 
 	switch (pool->type) {
 	case VK_QUERY_TYPE_OCCLUSION:
-- 
2.15.0



More information about the mesa-dev mailing list