[Mesa-dev] [PATCH] radv: do not add the query pool BO to the list in vkCmdEndQuery()

[Bas Nieuwenhuizen]

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Wed, Nov 15, 2017 at 10:55 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> As per the spec, the query identified by queryPool and query
> must currently be active. Applications have to call vkCmdBeginQuery()
> before, and thus the query pool BO will already be in the list.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_query.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
> index 6a80740ce0..5dc88af8f8 100644
> --- a/src/amd/vulkan/radv_query.c
> +++ b/src/amd/vulkan/radv_query.c
> @@ -1125,7 +1125,9 @@ void radv_CmdEndQuery(
>         uint64_t avail_va = va + pool->availability_offset + 4 * query;
>         va += pool->stride * query;
>
> -       radv_cs_add_buffer(cmd_buffer->device->ws, cs, pool->bo, 8);
> +       /* Do not need to add the pool BO to the list because the query must
> +        * currently be active, which means the BO is already in the list.
> +        */
>
>         switch (pool->type) {
>         case VK_QUERY_TYPE_OCCLUSION:
> --
> 2.15.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev