[Mesa-dev] [PATCH v4 11/13] meson: build gallium omx state tracker

[Emil Velikov]

Hi Dylan,

On 17 November 2017 at 00:27, Dylan Baker <dylan at pnwbakers.com> wrote:

> +  elif not (with_gallium_r600 or with_gallium_radeonsi or with_gallium_nouveau)


> +  elif not (with_gallium_r600 or with_gallium_radeonsi or with_gallium_nouveau)
> +    error('OMX state tracker requires at least one of the following gallium drivers: r600, radeonsi, nouveau.')

We had this type of dual tracking (once in configure and second in the
makefile) in the past for the autotools setup.
Sadly it was getting out of sync fairly often so Matt removed it.

In the odd case where an empty* target is build we'll effectively nuke
it as part of the hardlink generation process.

If you agreed, I won't bother respinning the series for that. One can
relax things as follow-up.

* A target where no driver is actually present, only the state-tracker
bits are there.

> --- a/src/gallium/meson.build
> +++ b/src/gallium/meson.build
> @@ -105,6 +105,9 @@ endif
>  if with_gallium_xvmc
>    subdir('state_trackers/xvmc')
>  endif
> +if with_gallium_omx
> +  subdir('state_trackers/omx_bellagio')
> +endif

> -# TODO: OMX
> +if with_gallium_omx
> +  subdir('targets/omx-bellagio')
> +endif
Grouping the state-tracker and target within the same if block will
make things easier to read.
Admittedly it's minor polish, so we can do that at later stage.

Last but not least: thanks for removing the overlinking for va/vdpau.

Emil