[Mesa-dev] [PATCH v4 11/13] meson: build gallium omx state tracker

[Dylan Baker]

Quoting Emil Velikov (2017-11-17 04:19:22)
> Hi Dylan,
> 
> On 17 November 2017 at 00:27, Dylan Baker <dylan at pnwbakers.com> wrote:
> 
> > +  elif not (with_gallium_r600 or with_gallium_radeonsi or with_gallium_nouveau)
> 
> 
> > +  elif not (with_gallium_r600 or with_gallium_radeonsi or with_gallium_nouveau)
> > +    error('OMX state tracker requires at least one of the following gallium drivers: r600, radeonsi, nouveau.')
> 
> We had this type of dual tracking (once in configure and second in the
> makefile) in the past for the autotools setup.
> Sadly it was getting out of sync fairly often so Matt removed it.

How often do new drivers get added to media state trackers (real question)? It
seems like the kind of thing that doesn't happen all that often and good review
should catch.

> 
> In the odd case where an empty* target is build we'll effectively nuke
> it as part of the hardlink generation process.

That seems... ugly. And it builds more than we need to since we wouldn't
actually end up installing the state tracker. It would also confuse the heck out
of me if I had turned OMX on and then didn't get an OMX driver or an error.

> 
> If you agreed, I won't bother respinning the series for that. One can
> relax things as follow-up.
> 
> * A target where no driver is actually present, only the state-tracker
> bits are there.
> 
> > --- a/src/gallium/meson.build
> > +++ b/src/gallium/meson.build
> > @@ -105,6 +105,9 @@ endif
> >  if with_gallium_xvmc
> >    subdir('state_trackers/xvmc')
> >  endif
> > +if with_gallium_omx
> > +  subdir('state_trackers/omx_bellagio')
> > +endif
> 
> > -# TODO: OMX
> > +if with_gallium_omx
> > +  subdir('targets/omx-bellagio')
> > +endif
> Grouping the state-tracker and target within the same if block will
> make things easier to read.
> Admittedly it's minor polish, so we can do that at later stage.

I have some patches built on top of this that do that grouping, as well as some
other cleanups that I'm pretty happy with the result of for handling linking
drivers into state trackers.

> 
> Last but not least: thanks for removing the overlinking for va/vdpau.
> 
> Emil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171117/a6c39510/attachment.sig>