[Mesa-dev] [PATCH 1/5] configure.ac: add Wundef to the build flags

[Emil Velikov]

On 24 November 2017 at 14:32, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> On Friday, 2017-11-24 14:25:02 +0000, Emil Velikov wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> From the manual:
>>   Warn if an undefined identifier is evaluated in an `#if' directive.
>>
>> This is something we want to know and address. Otherwise we can end up
>> with subtle issues, in the less commonly used codepaths.
>>
>> Note: this will trigger a lot of extra warnings, with ~60 of those being
>> unique. Once all those are resolved we'd want to promote the warning to
>> an error.
>
> Yes please; series is
> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
>
Thanks. I think we should hold these off, until some (say 1/3?) of the
issues are resolved.
Otherwise devs might get a bit annoyed my the massive amount of warnings.

-Emil