[Mesa-dev] [PATCH 1/5] configure.ac: add Wundef to the build flags

[Eric Engestrom]

On Friday, 2017-11-24 18:14:41 +0000, Emil Velikov wrote:
> On 24 November 2017 at 14:32, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> > On Friday, 2017-11-24 14:25:02 +0000, Emil Velikov wrote:
> >> From: Emil Velikov <emil.velikov at collabora.com>
> >>
> >> From the manual:
> >>   Warn if an undefined identifier is evaluated in an `#if' directive.
> >>
> >> This is something we want to know and address. Otherwise we can end up
> >> with subtle issues, in the less commonly used codepaths.
> >>
> >> Note: this will trigger a lot of extra warnings, with ~60 of those being
> >> unique. Once all those are resolved we'd want to promote the warning to
> >> an error.
> >
> > Yes please; series is
> > Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> >
> Thanks. I think we should hold these off, until some (say 1/3?) of the
> issues are resolved.
> Otherwise devs might get a bit annoyed my the massive amount of warnings.

Agreed. The series I just sent fixes 99% of the warnings already,
because c99_{compat,math}.h is included everywhere.

Once that series and your gtest patches land, if think it should be good
enough, and individual devs can take care of the rest.

The next biggest offender is Nouveau, and I haven't had a proper look
but at a glance I think it looked like it was probably just a few places
generating many warnings.