[Mesa-dev] [PATCH mesa 09/16] amd/addrlib: add comment about breakpoint not working in some cases

Marek Olšák maraeo at gmail.com
Fri Nov 24 18:25:45 UTC 2017


I'd like to keep the code as-is, because addrlib is an external project.

Marek

On Fri, Nov 24, 2017 at 7:07 PM, Eric Engestrom
<eric.engestrom at imgtec.com> wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
>  src/amd/addrlib/core/addrcommon.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/addrlib/core/addrcommon.h b/src/amd/addrlib/core/addrcommon.h
> index 1a7473a4d33c1271f077..9261c5890903d0dc1c0b 100644
> --- a/src/amd/addrlib/core/addrcommon.h
> +++ b/src/amd/addrlib/core/addrcommon.h
> @@ -51,7 +51,7 @@
>  ////////////////////////////////////////////////////////////////////////////////////////////////////
>  #ifdef DEBUG
>      #if defined(__GNUC__)
> -        #define ADDR_DBG_BREAK()    assert(false)
> +        #define ADDR_DBG_BREAK()    assert(false) /* FIXME: this can't work on debug builds with asserts off */
>      #elif defined(__APPLE__)
>          #define ADDR_DBG_BREAK()    { IOPanic("");}
>      #else
> --
> Cheers,
>   Eric
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list