[Mesa-dev] [PATCH 2/3] radv: Use the suffixed versions of VK_QUEUE_GLOBAL_PRIORITY_*

[Jason Ekstrand]

On Mon, Nov 27, 2017 at 7:00 PM, Ian Romanick <idr at freedesktop.org> wrote:

> I am strongly in favor of this precedent.  One thing that has annoyed me
> for years about Mesa's OpenGL code is the use of mixed suffixes through
> the code base as an extension progresses from vendor -> EXT -> ARB -> core.
>

I'm having a bit of trouble with English, I'm afraid.  I'm not sure if that
means you like the patch or hate it.  In any case, the related extension is
*not* in core and the lack of suffixes was a bug. The header/XML update I
sent out as patch 1/3 will break the radv build if we don't have this patch.

--Jason


> On 11/27/2017 06:36 PM, Jason Ekstrand wrote:
> > ---
> >  src/amd/vulkan/radv_device.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> > index 722c768..8e5ae0b 100644
> > --- a/src/amd/vulkan/radv_device.c
> > +++ b/src/amd/vulkan/radv_device.c
> > @@ -895,13 +895,13 @@ radv_get_queue_global_priority(const
> VkDeviceQueueGlobalPriorityCreateInfoEXT *p
> >               return RADEON_CTX_PRIORITY_MEDIUM;
> >
> >       switch(pObj->globalPriority) {
> > -     case VK_QUEUE_GLOBAL_PRIORITY_REALTIME:
> > +     case VK_QUEUE_GLOBAL_PRIORITY_REALTIME_EXT:
> >               return RADEON_CTX_PRIORITY_REALTIME;
> > -     case VK_QUEUE_GLOBAL_PRIORITY_HIGH:
> > +     case VK_QUEUE_GLOBAL_PRIORITY_HIGH_EXT:
> >               return RADEON_CTX_PRIORITY_HIGH;
> > -     case VK_QUEUE_GLOBAL_PRIORITY_MEDIUM:
> > +     case VK_QUEUE_GLOBAL_PRIORITY_MEDIUM_EXT:
> >               return RADEON_CTX_PRIORITY_MEDIUM;
> > -     case VK_QUEUE_GLOBAL_PRIORITY_LOW:
> > +     case VK_QUEUE_GLOBAL_PRIORITY_LOW_EXT:
> >               return RADEON_CTX_PRIORITY_LOW;
> >       default:
> >               unreachable("Illegal global priority value");
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171127/784b3559/attachment-0001.html>