[Mesa-dev] [PATCH] mesa: Document ati_fragment_shader::cur_pass

[Roland Scheidegger]

I really don't think you wanted to remove the cur_pass variable there :-).
With that fixed,
Reviewed-by: Roland Scheidegger <sroland at vmware.com>

Am 28.11.2017 um 04:10 schrieb Ian Romanick:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
> Having this information would have helped me review recent patches from
> Miklós...
> 
>  src/mesa/main/mtypes.h | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> index 2f21633..e753438 100644
> --- a/src/mesa/main/mtypes.h
> +++ b/src/mesa/main/mtypes.h
> @@ -2390,8 +2390,16 @@ struct ati_fragment_shader
>     GLubyte numArithInstr[2];
>     GLubyte regsAssigned[2];
>     GLubyte NumPasses;         /**< 1 or 2 */
> -   GLubyte cur_pass;
> +
> +   /**
> +    * cur_pass distinguishes between the texture and arithmetic phases.  There
> +    * are a maximum of two passes, and each pass has a texture phase followed
> +    * by an arithmetic phase.  Hence cur_pass being 0 means currently texture
> +    * instructions are specified for the first pass. cur_pass 1 arithmetic for
> +    * the first pass. cur_pass 2/3 correspond to the second pass accordingly.
> +    */
>     GLubyte last_optype;
> +
>     GLboolean interpinp1;
>     GLboolean isValid;
>     GLuint swizzlerq;
>