[Mesa-dev] [PATCH 2/6] i965: Use old_bo->align when growing batch/state buffer instead of 4096.

Jordan Justen jordan.l.justen at intel.com
Wed Nov 29 10:07:51 UTC 2017


Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

On 2017-11-28 16:13:17, Kenneth Graunke wrote:
> The intention here is make the new BO use the same alignment as the old
> BO.  This isn't strictly necessary, but we would have to update the
> 'alignment' field in the validation list when swapping it out, and we
> don't bother today.
> 
> The batch and state buffers use an alignment of 4096, so this should be
> equivalent - it's just clearer than cut and pasting a magic constant.
> 
> Fixes: 2dfc119f22f257082ab0 "i965: Grow the batch/state buffers if we need space and can't flush."
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103101
> ---
>  src/mesa/drivers/dri/i965/intel_batchbuffer.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> index 1d0292b4b80..2071faf85c2 100644
> --- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> +++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> @@ -302,7 +302,8 @@ grow_buffer(struct brw_context *brw,
>     uint32_t *old_map = *map_ptr;
>     struct brw_bo *old_bo = *bo_ptr;
>  
> -   struct brw_bo *new_bo = brw_bo_alloc(bufmgr, old_bo->name, new_size, 4096);
> +   struct brw_bo *new_bo =
> +      brw_bo_alloc(bufmgr, old_bo->name, new_size, old_bo->align);
>     uint32_t *new_map;
>  
>     perf_debug("Growing %s - ran out of space\n", old_bo->name);
> -- 
> 2.15.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list