[Mesa-dev] [PATCH 2/6] i965: Use old_bo->align when growing batch/state buffer instead of 4096.

Chris Wilson chris at chris-wilson.co.uk
Wed Nov 29 10:16:58 UTC 2017


Quoting Kenneth Graunke (2017-11-29 00:13:17)
> The intention here is make the new BO use the same alignment as the old
> BO.  This isn't strictly necessary, but we would have to update the
> 'alignment' field in the validation list when swapping it out, and we
> don't bother today.
> 
> The batch and state buffers use an alignment of 4096, so this should be
> equivalent - it's just clearer than cut and pasting a magic constant.

Whilst we are here, we could perhaps acknowledge that the required
alignment is only 64. (I'm presuming that the value is given only for
documentary purposes, anything less than 4k is ignored.)
-Chris


More information about the mesa-dev mailing list