[Mesa-dev] [PATCH v2 2/2] egl/wayland: Don't use dmabuf with no modifiers

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 3 15:26:04 UTC 2017


On 2 October 2017 at 17:31, Daniel Stone <daniels at collabora.com> wrote:
> The dmabuf interface requires a valid modifier to be sent. If we don't
> explicitly get a modifier from the driver, we can't know what to send;
> it must be inferred from legacy side-channels (or assumed to linear, if
> none exists).
>
> If we have no modifier, then we can only have a single-plane format
> anyway, so fall back to the old wl_drm buffer import path.
>
Small suggestion, please squash locally before pushing:

Please mention that single-plane format + dmabuf was assumed to work
but doesn't.

With that the series is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks
Emil


More information about the mesa-dev mailing list