[Mesa-dev] [PATCH v2 2/2] egl/wayland: Don't use dmabuf with no modifiers

[Emil Velikov]

Hi Dan,

Small question, which is somewhat orthogonal to the patch. Sorry :-\

On 2 October 2017 at 17:31, Daniel Stone <daniels at collabora.com> wrote:

>
> -   if (dri2_dpy->wl_dmabuf && dri2_dpy->image->base.version >= 15) {
> -      struct zwp_linux_buffer_params_v1 *params;
> +   if (dri2_dpy->image->base.version >= 15) {
Why are we using 15 here?

AFAICT the __DRI_IMAGE_ATTRIB_MODIFIER_{UPPER,LOWER} attributes were
introduced with v14.
Even then there should be no need for a check, since older versions
will just bail and we'll end up with DRM_FORMAT_MOD_INVALID.

Worth adding a small comment or dropping it all together?

Thanks
Emil