[Mesa-dev] [Bug 103031] [llvmpipe] piglit fs-discard-exit-2 fails with llvm-6.0

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Oct 5 22:34:11 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=103031

--- Comment #2 from Vinson Lee <vlee at freedesktop.org> ---
(In reply to Roland Scheidegger from comment #1)
> Created attachment 134554 [details] [review]
> patch accounting for llvm nuked pabs intrinsics
> 
> Does this patch work?
> I'm also changing the non-intrinsic definition of pabs to basically match
> what the auto-upgrader would do (if it would actually work for us...), so
> that llvm should be able to hopefully match that back to a pabs in the end
> (albeit the cmp/select has additional sext/trunc - I hope that doesn't
> matter...) - the old code would have used a max, which would have to be
> decomposed into a cmp/select too with newer llvm versions but it would have
> used select(cmp(greater, a, neg(a))) instead of select(cmp(greater, a, 0),
> neg(a)). Not sure if that would also get fused to a pabs instruction in the
> end...

Yes, this patch fixes the llvm.x86.avx2.pabs.d error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171005/fc0fb3da/attachment.html>


More information about the mesa-dev mailing list