[Mesa-dev] [PATCH 1/2] st/glsl_to_tgsi: ignore GL_TEXTURE_SRGB_DECODE_EXT for samplers used with texelFetch*()

[Kenneth Graunke]

On Friday, October 6, 2017 1:39:50 PM PDT Nicolai Hähnle wrote:
> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
> 
> See the comment for the relevant spec quote.
> 
> Fixes dEQP-GLES31.functional.srgb_texture_decode.skip_decode.srgba8.texel_fetch
> --
> Note that this is on top of the texture locking series which I have
> sent out a minute ago.
> ---
>  src/mesa/main/mtypes.h                     |  1 +
>  src/mesa/state_tracker/st_atom_texture.c   | 39 +++++++++++++++++++++++++++---
>  src/mesa/state_tracker/st_cb_texture.c     |  8 +++++-
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp |  4 +++
>  src/mesa/state_tracker/st_sampler_view.c   | 19 +++++++++------
>  src/mesa/state_tracker/st_sampler_view.h   |  3 ++-
>  src/mesa/state_tracker/st_texture.c        |  7 +++++-
>  src/mesa/state_tracker/st_texture.h        |  7 +++---
>  8 files changed, 71 insertions(+), 17 deletions(-)

Heh.  I was going to send out patches for i965 shortly.  I did this
by adding a new shader_info field instead, and populating it from
nir_shader_gather_info().  I obviously won't be able to reuse your
code in st_glsl_to_tgsi, but maybe I can reuse the field at least.

This looks good at any rate, no need to wait for me...

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171006/afe78dcd/attachment.sig>